Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move Primer::Markdown to Primer::Beta::Markdown #1681

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Dec 6, 2022

Description

moving Primer::Markdown to Primer::Beta::Markdown, and deprecating the original

Integration

Does this change require any updates to code in production?

no immediate changes needed, but deprecations need to be cleaned up

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2022

🦋 Changeset detected

Latest commit: fc38ac2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Dec 6, 2022
@mxriverlynn mxriverlynn mentioned this pull request Dec 6, 2022
54 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@mxriverlynn mxriverlynn force-pushed the mxriverlynn/move-markdown-to-beta branch from 312ff50 to fc38ac2 Compare December 6, 2022 20:42
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 6, 2022 20:47 Inactive
@mxriverlynn mxriverlynn marked this pull request as ready for review December 6, 2022 20:48
@mxriverlynn mxriverlynn merged commit 0c9611f into main Dec 6, 2022
@mxriverlynn mxriverlynn deleted the mxriverlynn/move-markdown-to-beta branch December 6, 2022 23:33
@primer-css primer-css mentioned this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants