Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move Primer::LocalTime to Primer::Alpha::LocalTime #1675

Closed
wants to merge 7 commits into from

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Dec 6, 2022

Description

this PR moved Primer::LocalTime to Primer::Alpha::LocalTime, and deprecates the original.

it also makes several adjustments to the component_status_migrator thor script:

  • handle inconsistency between preview file name and component file name / class name
  • move all the misc files that come with a component (javascript, css, etc)
  • correct the primer.ts file imports

Integration

Does this change require any updates to code in production?

no immediate changes are required, but component deprecations will need to be taken care of

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2022

🦋 Changeset detected

Latest commit: 48815ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added javascript Pull requests that update Javascript code ruby Pull requests that update Ruby code labels Dec 6, 2022
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 6, 2022 17:07 Inactive
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1675 December 6, 2022 17:10 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 6, 2022 17:13 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 6, 2022 17:32 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@mxriverlynn mxriverlynn force-pushed the mxriverlynn/move-local-time-to-alpha branch from cefd2ec to 457ae3f Compare December 6, 2022 17:54
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1675 December 6, 2022 17:54 Inactive
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1675 December 6, 2022 18:10 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 6, 2022 18:15 Inactive
@mxriverlynn mxriverlynn marked this pull request as ready for review December 6, 2022 18:32
@keithamus
Copy link
Member

We may want to move this all the way to Deprecated (or remove it?) as RelativeTime will replace this.

@mxriverlynn
Copy link
Contributor Author

closed in favor of #1687

@mxriverlynn mxriverlynn closed this Dec 7, 2022
@jonrohan jonrohan deleted the mxriverlynn/move-local-time-to-alpha branch February 13, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants