Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forms immediate server side validation #1672

Merged
merged 15 commits into from
Dec 8, 2022
Merged

forms immediate server side validation #1672

merged 15 commits into from
Dec 8, 2022

Commits on Dec 8, 2022

  1. FormControl tests 

    This sets up a place to test form text fields that will automatically
validate against the server. It makes tests around the existing text
field functionality without the auto-server-validation.

I pulled out the DeepMind fake model from an existing test file in order
to share it with this new test file.
    @neall
    neall committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e25a8b7 View commit details
    Browse the repository at this point in the history

  2. Add JavaScript to form text_fields 

    This will allow us to validate a text field against the server with
JavaScript using custom elements.
    @neall
    neall committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e7570ba View commit details
    Browse the repository at this point in the history

  3. Only have text-field data attributes when needed 

    When we show the validation elements, only include the data-target
attributes when we need them.
    @neall
    neall committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3893bb0 View commit details
    Browse the repository at this point in the history

  4. Include forms js in bundle

    @camertron @neall
    camertron authored and neall committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    6875def View commit details
    Browse the repository at this point in the history

  5. Include correct authenticity token in auto-check requests

    @camertron @neall
    camertron authored and neall committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e0c11d7 View commit details
    Browse the repository at this point in the history

  6. Watch lib/primer/forms for ts changes; ensure components are full-width

    @camertron @neall
    camertron authored and neall committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    cabfedc View commit details
    Browse the repository at this point in the history

  7. Generating component snapshots

    @neall
    neall committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e9dd173 View commit details
    Browse the repository at this point in the history

  8. Rename from <text-field> to <primer-text-field> 

    We decided that `text-field` was a bit too generic a name for the global
custom element namespace on a page.
    @neall
    neall committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    a75bba1 View commit details
    Browse the repository at this point in the history

  9. Add AbortController to primer-text-field 

    Prevent PrimerTextField event handlers from hanging around in weird
cases.

Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
    @neall @keithamus
    neall and keithamus committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    740b46a View commit details
    Browse the repository at this point in the history

  10. describe branch in changeset message

    @neall
    neall committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e3e6976 View commit details
    Browse the repository at this point in the history

  11. Deploy assets from the entire demo lib dir 

    We were only deploying lib assets under `lib/postcss_mixins`, but now we
have JavaScript coming from the lib directory as well.
    @neall
    neall committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    6b0c5e9 View commit details
    Browse the repository at this point in the history

  12. Exclude example form from coverage requirements 

    The underlying functionality is tested somewhere else, and these example
forms are not used in the built gem.
    @neall
    neall committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    d5466b7 View commit details
    Browse the repository at this point in the history

  13. Put a note in rollup config about debuggers 

    Terser seems to be eliminating debugger statements during minification
and we couldn't figure out why. For now, if you want to use the debugger
in development you can comment out the line that adds the Terser plugin
to Rollup.
    @neall
    neall committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    33acbe2 View commit details
    Browse the repository at this point in the history

  14. Fix routes

    @camertron
    camertron committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    80c0227 View commit details
    Browse the repository at this point in the history

  15. Merging upstream changes

    @camertron
    camertron committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3fd3217 View commit details
    Browse the repository at this point in the history