Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration guide for Primer::DropdownMenuComponent to Primer::Beta::Dropdown #1671

Merged
merged 11 commits into from
Dec 5, 2022

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Dec 5, 2022

Description

Adds a migration guide for moving from Primer::DropdownMenuComponent to Primer::Beta::Dropdown.

Adds a new "Deprecated Components" section to the site navigation, with links to existing documentation for deprecated components. Note that not all deprecated components have previous documentation, so not all of them show up in the nav

Organizes the lib/primer/deprecations.yml file so it's now alphabetized, and a bit easier to read with spacing between components

Screenshots

migration guide listing page:
image

migration guide:
image

new Deprecated Components menu nav:
image

Integration

Does this change require any updates to code in production?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2022

🦋 Changeset detected

Latest commit: 1d54015

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxriverlynn mxriverlynn temporarily deployed to review-pr-1671 December 5, 2022 15:44 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 5, 2022 15:49 Inactive
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1671 December 5, 2022 16:06 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 5, 2022 16:11 Inactive
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1671 December 5, 2022 17:24 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 5, 2022 17:29 Inactive
@mxriverlynn mxriverlynn force-pushed the mxriverlynn/dropdown-menu-guide branch from 52eaf90 to 6b9ba1e Compare December 5, 2022 17:48
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1671 December 5, 2022 17:48 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 5, 2022 17:53 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 5, 2022 18:40 Inactive
@mxriverlynn mxriverlynn marked this pull request as ready for review December 5, 2022 18:43
@mxriverlynn mxriverlynn requested review from a team, keithamus and jonrohan December 5, 2022 18:43
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mxriverlynn mxriverlynn merged commit e0be277 into main Dec 5, 2022
@mxriverlynn mxriverlynn deleted the mxriverlynn/dropdown-menu-guide branch December 5, 2022 19:11
@primer-css primer-css mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants