Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating AUDITED variable to access audited_at static file #1662

Merged
merged 3 commits into from
Dec 2, 2022

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Dec 1, 2022

Description

I want to be able to access the static/audited_at.json file using the Primer::ViewComponents::AUDITED static variable. This was made to be exactly like Primer::ViewComponents::STATUSES.

Integration

Does this change require any updates to code in production?

No

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@jonrohan jonrohan requested review from a team and keithamus December 1, 2022 22:45
@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2022

🦋 Changeset detected

Latest commit: 05ef8be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan temporarily deployed to review-pr-1662 December 1, 2022 22:47 Inactive
@jonrohan jonrohan temporarily deployed to github-pages December 1, 2022 22:51 Inactive
@jonrohan jonrohan temporarily deployed to github-pages December 2, 2022 01:33 Inactive
@jonrohan jonrohan enabled auto-merge (squash) December 2, 2022 01:41
@jonrohan jonrohan changed the title Creating AUDITED variable to access Creating AUDITED variable to access audited_at static file Dec 2, 2022
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me. 👍

@jonrohan jonrohan merged commit d2b3360 into main Dec 2, 2022
@jonrohan jonrohan deleted the audited_class branch December 2, 2022 15:29
@primer-css primer-css mentioned this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants