Move Overlay styles to PVC
#1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently they can't be nested
🦋 Changeset detectedLatest commit: 970da65 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simurai
commented
Dec 1, 2022
Comment on lines
+290
to
+293
| /* Override .close-button's `border: 0` that triggers a border-color transition on hover */ | ||
| &.close-button { | ||
| border: var(--primer-borderWidth-thin, 1px) solid transparent; | ||
| } |
There was a problem hiding this comment.
Without this override the border would transition:
border-color: initial(dark gray) ->border-color: transparent
Screen.Recording.2022-12-01.at.15.59.29.mov
Might not be needed once Primer::Beta::CloseButton is updated to IconButton.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of #1342 and an alternative to #1648. It adds the
Overlaystyles from PCSS. There should be no visual changes.In #1401 we can eventually rename
dialog.pcss->overlay.pcss, but this PR is intended to be ready before, see #1648 (review).Integration
Yes, the following lines can be removed on dotcom:
- @import '@primer/css/overlay/overlay.scss';Merge checklist
Added/updated testsAdded/updated documentationAdded/updated previews