Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check accessibility of previews with axe-core npm package. #1588

Merged
merged 27 commits into from
Jan 19, 2023
Merged

Check accessibility of previews with axe-core npm package. #1588

merged 27 commits into from
Jan 19, 2023

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented Nov 9, 2022 •
edited
Loading

Description

Use axe-core from npm in Cuprite System tests. I also made sure to update to axe-core@4.5.

Integration

Does this change require any updates to code in production?

No

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

References

Closes https://github.com/github/platform-ux/issues/1122

@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: be3fafa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@koddsson koddsson temporarily deployed to github-pages November 9, 2022 12:37 Inactive
@koddsson koddsson temporarily deployed to review-pr-1588 November 9, 2022 12:42 Inactive
@koddsson koddsson temporarily deployed to github-pages November 9, 2022 12:46 Inactive
@koddsson koddsson temporarily deployed to review-pr-1588 November 9, 2022 13:39 Inactive
@koddsson koddsson temporarily deployed to github-pages November 9, 2022 13:43 Inactive
@koddsson koddsson temporarily deployed to review-pr-1588 November 9, 2022 13:52 Inactive
@koddsson koddsson temporarily deployed to github-pages November 9, 2022 13:56 Inactive
@koddsson koddsson temporarily deployed to review-pr-1588 November 9, 2022 15:00 Inactive
@koddsson koddsson temporarily deployed to github-pages November 9, 2022 15:04 Inactive
@koddsson koddsson temporarily deployed to review-pr-1588 November 9, 2022 15:36 Inactive
@koddsson koddsson temporarily deployed to github-pages November 9, 2022 15:41 Inactive
@koddsson
Copy link
Contributor Author

If we switch to playwright, then the https://www.npmjs.com/package/@axe-core/playwright axe-core playwright package might be easier to use?

Yeah! I'm sure @axe-core/playwright would be pretty much plug and play into a JS playwright setup. This PR plugs better into our existing test infrastructure. I think using playwright directly instead of Capybara is the way to go eventually but I'd prefer to have it implemented in ruby with the existing tests.

camertron
camertron requested changes Nov 21, 2022
View reviewed changes
test/system/test_case.rb Outdated Show resolved Hide resolved
previews/primer/alpha/tooltip_preview.rb Show resolved Hide resolved
@khiga8 khiga8 linked an issue Nov 22, 2022 that may be closed by this pull request
Blocked from upgrading axe-core-api because cuprite support dropped in latest versions #1380
Closed
@github-actions
Copy link
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@camertron camertron temporarily deployed to review-pr-1588 January 19, 2023 19:21 — with GitHub Actions Inactive
@camertron camertron temporarily deployed to review-pr-1588 January 19, 2023 20:00 — with GitHub Actions Inactive
@camertron camertron merged commit e389a55 into main Jan 19, 2023
@camertron camertron deleted the system-tests branch January 19, 2023 21:02
@primer-css primer-css mentioned this pull request Jan 19, 2023
Merged
@camertron camertron mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@keithamus keithamus keithamus approved these changes

@camertron camertron camertron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blocked from upgrading axe-core-api because cuprite support dropped in latest versions
4 participants
@koddsson @jonrohan @keithamus @camertron