Move Banner to alpha namespace #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 755b661 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
css
Co-authored-by: Jon Rohan <rohan@github.com>
jonrohan
approved these changes
Nov 7, 2022
…nts into move_banner_to_alpha
Merged
siddharthkp
added a commit
that referenced
this pull request
Nov 17, 2022
Banner was moved to alpha in #1579
jonrohan
pushed a commit
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Bannercomponent currently lives in theBetanamespace because it will eventually form the basis of theFlashcomponent, which is also inBeta. However, sinceBanneruses new markup and new styles, it's more correct for it to be in theAlphanamespace. It will need to be evaluated against the beta criteria before being elevated to that status.Integration
Yes. There are only a few instances of
Primer::Beta::Bannerin production though, so the migration should be easy.Merge checklist