Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component-Specific CSS Selector Tests #1574

Merged
merged 48 commits into from
Nov 10, 2022
Merged

Component-Specific CSS Selector Tests #1574

merged 48 commits into from
Nov 10, 2022

Commits on Nov 3, 2022

  1. added first pass at making a working css selector test for components

    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    03537e3 View commit details
    Browse the repository at this point in the history

  2. working on a bit more code organization and error message for failed … 

    …test
    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    2cb6eca View commit details
    Browse the repository at this point in the history

  3. loop through all the components with previews, and test the selectors… 

    … for each
    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    fee5bf6 View commit details
    Browse the repository at this point in the history

  4. correcting the test method name generation

    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    500f9a6 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into mxriverlynn/component… 

    …-css-selector-tests
    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    4586618 View commit details
    Browse the repository at this point in the history

  6. better failure message and code to generate it

    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    558a8c8 View commit details
    Browse the repository at this point in the history

  7. improving assertion so it doesn't muddy failure messages with the def… 

    …ault, less useful message
    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    f0f2e28 View commit details
    Browse the repository at this point in the history

  8. further improvements to the failure message

    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    59773f3 View commit details
    Browse the repository at this point in the history

  9. ignored 'to' selector

    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    23576d5 View commit details
    Browse the repository at this point in the history

  10. rubocop cleanup

    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    63dea07 View commit details
    Browse the repository at this point in the history

  11. code cleanup for remaining selectors

    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    fde18ee View commit details
    Browse the repository at this point in the history

  12. update ignored_selectors to allow global vs component specific ignore… 

    …s, by component class
    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    b517060 View commit details
    Browse the repository at this point in the history

  13. added a few comments about the dynamic test generation

    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    68675cd View commit details
    Browse the repository at this point in the history

  14. adding a few previews to banner, to help coverage of the selectors an… 

    …d options in preview
    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    5e4c78a View commit details
    Browse the repository at this point in the history

  15. another round of previews for banner

    @mxriverlynn
    mxriverlynn committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    20f01b0 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. correcting rendering of banner previews

    @mxriverlynn
    mxriverlynn committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    1e6572d View commit details
    Browse the repository at this point in the history

  2. typo

    @mxriverlynn
    mxriverlynn committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    0c189a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Update test/components/css/css_selector_test.rb 

    Co-authored-by: Jon Rohan <rohan@github.com>
    @mxriverlynn @jonrohan
    mxriverlynn and jonrohan authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    b4f5e79 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into mxriverlynn/component… 

    …-css-selector-tests
    @mxriverlynn
    mxriverlynn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    b11c361 View commit details
    Browse the repository at this point in the history

  3. rubocop cleanup

    @mxriverlynn
    mxriverlynn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    aa3d7c5 View commit details
    Browse the repository at this point in the history

  4. improving test comments

    @mxriverlynn
    mxriverlynn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    12c23e3 View commit details
    Browse the repository at this point in the history

  5. correcting banner to alpha in preview

    @mxriverlynn
    mxriverlynn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    1613097 View commit details
    Browse the repository at this point in the history

  6. added dismissable preview for banner

    @mxriverlynn
    mxriverlynn committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    34ae502 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Merge remote-tracking branch 'origin/main' into mxriverlynn/component… 

    …-css-selector-tests
    @mxriverlynn
    mxriverlynn committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    c00343f View commit details
    Browse the repository at this point in the history

  2. ignore the banner close selector since it's not used at the moment

    @mxriverlynn
    mxriverlynn committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    a089996 View commit details
    Browse the repository at this point in the history

  3. correcting comment style

    @mxriverlynn
    mxriverlynn committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    43e8c0c View commit details
    Browse the repository at this point in the history

  4. rebuilt segmented control preview to include more of the available op… 

    …tions, grouped together appropriately
    @mxriverlynn
    mxriverlynn committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    66373d2 View commit details
    Browse the repository at this point in the history

  5. segmented control selector ignore and question

    @mxriverlynn
    mxriverlynn committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    bc741d0 View commit details
    Browse the repository at this point in the history

  6. correcting method named, and adding full width icon only preview

    @mxriverlynn
    mxriverlynn committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    1bfae15 View commit details
    Browse the repository at this point in the history

  7. full width sizes for segmented previews

    @mxriverlynn
    mxriverlynn committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    4ca094f View commit details
    Browse the repository at this point in the history

  8. correcting full width examples for segmented control

    @mxriverlynn
    mxriverlynn committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    6e7bcd0 View commit details
    Browse the repository at this point in the history

  9. added changeset

    @mxriverlynn
    mxriverlynn committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    6c2b5c7 View commit details
    Browse the repository at this point in the history

  10. adding progress bar size previews

    @mxriverlynn
    mxriverlynn committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    4610aa1 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Merge remote-tracking branch 'origin/main' into mxriverlynn/component… 

    …-css-selector-tests
    @mxriverlynn
    mxriverlynn committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    809b13f View commit details
    Browse the repository at this point in the history

  2. added Counter previews to demonstrate various rounding options

    @mxriverlynn
    mxriverlynn committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    83495b7 View commit details
    Browse the repository at this point in the history

  3. ignore Counter .ociton selector

    @mxriverlynn
    mxriverlynn committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    aeeae66 View commit details
    Browse the repository at this point in the history

  4. added some preview groups to banner preview

    @mxriverlynn
    mxriverlynn committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    e533709 View commit details
    Browse the repository at this point in the history

  5. moved component specific css test to new folder

    @mxriverlynn
    mxriverlynn committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    085ddf9 View commit details
    Browse the repository at this point in the history

  6. added component css specific test run

    @mxriverlynn
    mxriverlynn committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    e366725 View commit details
    Browse the repository at this point in the history

  7. Update .github/workflows/test_css.yml 

    Co-authored-by: Jon Rohan <rohan@github.com>
    @mxriverlynn @jonrohan
    mxriverlynn and jonrohan authored Nov 10, 2022
    Configuration menu
    Copy the full SHA
    36d2b19 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/main' into mxriverlynn/component… 

    …-css-selector-tests
    @mxriverlynn
    mxriverlynn committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    50f9c4f View commit details
    Browse the repository at this point in the history

  9. move css tests into test.yml

    @mxriverlynn
    mxriverlynn committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    d59febe View commit details
    Browse the repository at this point in the history

  10. Generating component snapshots

    @mxriverlynn @github-actions
    mxriverlynn authored and github-actions[bot] committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    fa3a4de View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'origin/mxriverlynn/component-css-select… 

    …or-tests' into mxriverlynn/component-css-selector-tests
    @mxriverlynn
    mxriverlynn committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    c2d1677 View commit details
    Browse the repository at this point in the history

  12. correcting preview rendering for segmented control tests

    @mxriverlynn
    mxriverlynn committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    2abdde5 View commit details
    Browse the repository at this point in the history

  13. removing comment that included an ampersand, because it was causing a… 

    … test failure
    @mxriverlynn
    mxriverlynn committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    49ed298 View commit details
    Browse the repository at this point in the history

  14. reset folder what's on main

    @mxriverlynn
    mxriverlynn committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    91187ee View commit details
    Browse the repository at this point in the history

  15. Generating component snapshots

    @mxriverlynn @github-actions
    mxriverlynn authored and github-actions[bot] committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    fa62e91 View commit details
    Browse the repository at this point in the history