Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't export web components #1560

Merged
merged 3 commits into from
Nov 1, 2022
Merged

Don't export web components #1560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63df1e3
Don't export SegmentedControlElement
safeforge Nov 1, 2022
8d0f96f
Don't export XBannerElement
safeforge Nov 1, 2022
0637065
Add changeset
keithamus Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-rabbits-glow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/view-components': patch
---

Avoid double-registering of exported components
2 changes: 1 addition & 1 deletion app/components/primer/alpha/segmented_control.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {controller, targets} from '@github/catalyst'

@controller
export class SegmentedControlElement extends HTMLElement {
class SegmentedControlElement extends HTMLElement {
@targets items: HTMLElement[]

connectedCallback() {
Expand Down
2 changes: 1 addition & 1 deletion app/components/primer/beta/x_banner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {controller, target} from '@github/catalyst'

@controller
export class XBannerElement extends HTMLElement {
class XBannerElement extends HTMLElement {
@target root: HTMLElement
@target titleText: HTMLElement

Expand Down