Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing snapshot testing related code #1555

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

jonrohan
Copy link
Member

Description

This removes the snapshot code I added. I found it was too unpredictable and sometimes would generate new snapshots after changes to the README.md file.

The closest I got to a fix for this is in #1455 but it was still having issues

image

So I'm opting to close and remove this until we can integrate something better. primer/react#2491

Integration

Does this change require any updates to code in production?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@jonrohan jonrohan requested review from a team and keithamus October 31, 2022 21:04
@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2022

⚠️ No Changeset found

Latest commit: 78b06ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh bummer! Hope we can find a better solution later :D

@jonrohan jonrohan merged commit 30a5ee0 into main Oct 31, 2022
@jonrohan jonrohan deleted the remove_snapshot_workflows branch October 31, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants