migrating Primer::ImageCrop to Primer::Alpha::ImageCrop #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a4a04fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
javascript
54 tasks
jonrohan
reviewed
Oct 20, 2022
| @@ -7,21 +7,21 @@ class ImageCropPreview < ViewComponent::Preview | |||
| # | |||
There was a problem hiding this comment.
It's probably my fault not updating the migration script properly, but this whole file should move to previews/primer/alpha also
jonrohan
approved these changes
Oct 20, 2022
Merged
mxriverlynn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR migrates
Primer::ImageCroptoPrimer::Alpha::ImageCrop, and marks the original as deprecatedIntegration
migrating files that use
Primer::ImageCropbut not immediately. deprecations will be raised when a file that uses it is editedMerge checklist