Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Primer::Image to Primer::Alpha::Image #1527

Merged
merged 4 commits into from
Oct 20, 2022

Conversation

mxriverlynn
Copy link
Contributor

Description

this PR migrates Primer::Image to Primer::Alpha::Image, and marks the original as deprecated.

Integration

Does this change require any updates to code in production?

yes, but not immediately. deprecations will show in dotcom when someone is modifying a file that currently uses Primer::Image

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2022

🦋 Changeset detected

Latest commit: 28f5f0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxriverlynn mxriverlynn marked this pull request as ready for review October 20, 2022 19:03
@mxriverlynn mxriverlynn requested review from a team and BlakeWilliams October 20, 2022 19:03
@mxriverlynn mxriverlynn merged commit 595a675 into main Oct 20, 2022
@mxriverlynn mxriverlynn deleted the mxriverlynn/primer-image-naming branch October 20, 2022 19:08
@mxriverlynn mxriverlynn mentioned this pull request Oct 20, 2022
54 tasks
@primer-css primer-css mentioned this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants