Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move tooltip to be adjacent to button #1479

Merged
merged 2 commits into from
Oct 11, 2022
Merged

move tooltip to be adjacent to button #1479

merged 2 commits into from
Oct 11, 2022

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Oct 11, 2022

Description

Describe your changes here.

Closes #1473

Integration

no

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2022

🦋 Changeset detected

Latest commit: bc1678e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Oct 11, 2022
@khiga8 khiga8 temporarily deployed to github-pages October 11, 2022 13:17 Inactive
@khiga8 khiga8 temporarily deployed to github-pages October 11, 2022 13:31 Inactive
@khiga8 khiga8 marked this pull request as ready for review October 11, 2022 16:02
@khiga8 khiga8 requested review from a team and camertron October 11, 2022 16:02
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, oops, great catch.

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry we missed this 🙌

@khiga8 khiga8 merged commit b028103 into main Oct 11, 2022
@khiga8 khiga8 deleted the kh-move-tooltip branch October 11, 2022 16:05
@primer-css primer-css mentioned this pull request Oct 11, 2022
jonrohan pushed a commit that referenced this pull request Oct 11, 2022
* move tooltip

* Create mighty-moose-buy.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Primer::Beta::Button tooltip placement is wrong
3 participants