Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested dialogs #1471

Merged
merged 5 commits into from
Oct 10, 2022
Merged

Nested dialogs #1471

merged 5 commits into from
Oct 10, 2022

Conversation

koddsson
Copy link
Contributor

Make sure that nested dialogs work correctly.

I also removed some dead code, added a preview for nested dialog and made sure script/dev exists if overmind is not installed.

Closes #1366

@koddsson koddsson requested review from a team and camertron October 10, 2022 12:30
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2022

🦋 Changeset detected

Latest commit: 9b807ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Oct 10, 2022
@koddsson koddsson temporarily deployed to github-pages October 10, 2022 12:34 Inactive
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me

@jonrohan jonrohan merged commit 5687beb into main Oct 10, 2022
@jonrohan jonrohan deleted the nested-dialogs branch October 10, 2022 15:30
@primer-css primer-css mentioned this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested dialogs are dismissed immediately
3 participants