Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a merge checklist to release PRs #1434

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Adding a merge checklist to release PRs #1434

merged 2 commits into from
Sep 30, 2022

Conversation

jonrohan
Copy link
Member

This adds a pre-merge checklist to our Release PRs. I took this workflow and template from primer/react primer/react#2365 (comment)

I tried my best to edit for things we'll be interested in, but please suggest changes if I missed anything

@jonrohan jonrohan requested review from camertron, langermank and a team September 30, 2022 18:17
@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: cf780e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonrohan jonrohan added the skip changeset Pull requests that don't change the library output label Sep 30, 2022
@jonrohan jonrohan temporarily deployed to github-pages September 30, 2022 18:23 Inactive
camertron
camertron approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we need something like this? I don't really have a problem with it but wonder if we need it for every PR.

.github/release_template.md Outdated Show resolved Hide resolved
.github/release_template.md Outdated Show resolved Hide resolved
@jonrohan
Copy link
Member Author

I don't really have a problem with it but wonder if we need it for every PR.

It should only run on the Release PRs like this one #1433

langermank
langermank approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jonrohan @camertron
Apply suggestions from code review
cf780e7 
Co-authored-by: Cameron Dutro <camertron@gmail.com>
@jonrohan jonrohan enabled auto-merge (squash) September 30, 2022 18:30
@jonrohan jonrohan temporarily deployed to github-pages September 30, 2022 18:35 Inactive
@jonrohan jonrohan merged commit 3d45a3e into main Sep 30, 2022
@jonrohan jonrohan deleted the release_template branch September 30, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron camertron approved these changes

@langermank langermank langermank approved these changes

Assignees
No one assigned
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonrohan @camertron @langermank