Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG and custom content options to NavList's leading visual slot #1422

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

camertron
Copy link
Contributor

This PR adds SVG and custom content as options to NavList's leading visual slot.

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022

🦋 Changeset detected

Latest commit: cf2eaab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron temporarily deployed to review-pr-1422 September 29, 2022 19:04 Inactive
@camertron camertron temporarily deployed to github-pages September 29, 2022 20:08 Inactive
@camertron camertron marked this pull request as ready for review September 29, 2022 20:16
@camertron camertron requested review from a team, jonrohan and langermank and removed request for jonrohan September 29, 2022 20:16
Copy link
Contributor

@joelhawksley joelhawksley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Mind adding tests and a preview that shows this feature?

@camertron
Copy link
Contributor Author

@joelhawksley I don't think tests are necessary since they'd only be exercising polymorphic slots and BaseComponent, which are already well-covered. I'd be happy to add some previews though.

@camertron camertron enabled auto-merge (squash) September 29, 2022 21:18
@camertron camertron temporarily deployed to github-pages September 29, 2022 21:21 Inactive
@camertron camertron merged commit a129a4d into main Sep 29, 2022
@camertron camertron deleted the nav_list_leading_visual_additions branch September 29, 2022 21:25
@primer-css primer-css mentioned this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants