Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move previews into root and include in gemspec #1404

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Conversation

steves
Copy link
Contributor

@steves steves commented Sep 26, 2022

I paired on this with @joelhawksley. We've begun including Lookbook in github/github. If we include our primer/view_components previews in the gem then we can pull them into the local Lookbook instance. After some debate we also decided to move them out of test and into their own top level directory. It felt wrong including test files in the gem and previews really aren't tests. They can be used by tests but they are, themselves, not tests.

@steves steves requested review from a team and jonrohan September 26, 2022 15:39
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2022

⚠️ No Changeset found

Latest commit: edc9453

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@steves steves temporarily deployed to review-pr-1404 September 26, 2022 15:39 Inactive
@steves steves temporarily deployed to github-pages September 26, 2022 15:44 Inactive
@jonrohan jonrohan temporarily deployed to review-pr-1404 September 26, 2022 16:22 Inactive
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 👍🏻

@jonrohan jonrohan temporarily deployed to github-pages September 26, 2022 16:26 Inactive
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@steves steves temporarily deployed to review-pr-1404 September 27, 2022 15:37 Inactive
@steves steves temporarily deployed to github-pages September 27, 2022 15:41 Inactive
@jonrohan jonrohan enabled auto-merge (squash) September 28, 2022 17:03
@jonrohan jonrohan temporarily deployed to github-pages September 28, 2022 17:05 Inactive
@jonrohan jonrohan merged commit f31331f into main Sep 28, 2022
@jonrohan jonrohan deleted the steves-include-previews branch September 28, 2022 17:09
@primer-css primer-css mentioned this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants