Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let forks ✅ on main #1340

Merged
merged 7 commits into from
Aug 31, 2022
Merged

Let forks ✅ on main #1340

merged 7 commits into from
Aug 31, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Aug 28, 2022

closes #1033

https://github.com/jsoref/view_components/actions?query=branch%3Amain

Before

image

After

image

(Note that I've disabled CI because it's expensive, but I'm not changing anything relevant to CI.

The change to @return is included to show that there's a little value in not just skipping the entire workflow. Note that I have no particular preference between skipping an entire workflow or skipping a portion of a workflow.

@jsoref jsoref requested review from a team and keithamus August 28, 2022 16:48
@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2022

🦋 Changeset detected

Latest commit: a423f93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan enabled auto-merge (squash) August 31, 2022 21:07
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonrohan jonrohan merged commit a4f868c into primer:main Aug 31, 2022
@primer-css primer-css mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs-build fails on forks
2 participants