Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore compiled *.js *.css files #1332

Merged
merged 3 commits into from
Aug 24, 2022
Merged

Ignore compiled *.js *.css files #1332

merged 3 commits into from
Aug 24, 2022

Conversation

jonrohan
Copy link
Member

I keep getting merge conflicts in these files and wanted to ask if we could exclude them from git? They're all built from the prepare npm script so I believe they'd still exist in the npm package.

rm 'app/assets/javascripts/primer_view_components.js'
rm 'app/assets/javascripts/primer_view_components.js.map'
rm 'app/assets/styles/primer_view_components.css'
rm 'app/assets/styles/primer_view_components.css.map'
rm 'docs/static/primer_view_components.css'
rm 'docs/static/primer_view_components.css.map'
rm 'docs/static/primer_view_components.js'
rm 'docs/static/primer_view_components.js.map'

@jonrohan jonrohan requested review from a team and keithamus August 23, 2022 23:19
@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022

🦋 Changeset detected

Latest commit: 2ea5279

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan temporarily deployed to github-pages August 23, 2022 23:23 Inactive
@jonrohan jonrohan temporarily deployed to github-pages August 24, 2022 16:46 Inactive
@jonrohan jonrohan merged commit 3004d86 into main Aug 24, 2022
@jonrohan jonrohan deleted the ignore_built_js_css branch August 24, 2022 16:48
@primer-css primer-css mentioned this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant