Beta::Button and Beta::IconButton visual refinements #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1eb180c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Katie Langerman <langermank@users.noreply.github.com>
Co-authored-by: Katie Langerman <langermank@users.noreply.github.com>
langermank
changed the title
jonrohan
reviewed
Aug 30, 2022
|
|
||
| def test_docs_do_not_generate_primer_css_classes_that_do_not_exist | ||
| assert_empty(@classes_from_docs_build - @css_data - @allowed_missing_classes_for_now) | ||
| end |
There was a problem hiding this comment.
This test was looking for classes being used in the docs that weren't in the primer/css bundle. It's beginning to fail more as we transition to #1319 So I'm removing that part of the test
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
Betanamespace, this PR updates style and parameters for Button components based on this discussion and design recommendations.More refinement to come in a followup PR as we begin integrating
IconButtonintoCommentBox,Dialog, andActionList::Item