Update slot use in examples for all components in the beta folder #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e5c4d1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…onent-slot-updates
mxriverlynn
commented
Aug 10, 2022
| class Header < Primer::Component | ||
| status :beta |
There was a problem hiding this comment.
i was previously told sub components don't need a status, but i found that they show up as alpha status in static/statuses.json if they don't have one specifically set. so i think we should include them
mxriverlynn
changed the title
…onent-slot-updates
…updates' into mxriverlynn/beta-component-slot-updates
mxriverlynn
requested review from
a team,
keithamus,
camertron and
joelhawksley
joelhawksley
approved these changes
Aug 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR updates all components in the
beta/folder to use the new.with_#{slot_name}syntax in docs examplesit also adds the missing
status :betatoBeta::BorderBox::HeaderUpdated components
Screenshots
auto complete:
avatar stack:
border box:
bread crumbs:
button group:
flash:
truncate:
