Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating slot use in BorderBox examples to the '.with_#{slot_name}' syntax #1290

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Aug 9, 2022

as part of the slot use migration, this PR updates all slot use in the Primer::Beta::BorderBox examples to use .with_#{slot_name} instead of .#{slot_name}

  • .header -> .with_header
  • .row -> .with_row
  • .body -> .with_body
  • .footer -> .with_footer

notes

this PR is intentionally limited to one component, as a test to make sure everything is updated correctly

screenshots

updated docs site:
image

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2022

🦋 Changeset detected

Latest commit: df53b5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxriverlynn mxriverlynn temporarily deployed to github-pages August 9, 2022 19:42 Inactive
@mxriverlynn mxriverlynn changed the title [WIP] updating all slot use in BorderBox to the '.with_#{slot_name}' syntax updating all slot use in BorderBox to the '.with_#{slot_name}' syntax Aug 9, 2022
@mxriverlynn mxriverlynn marked this pull request as ready for review August 9, 2022 19:52
@mxriverlynn mxriverlynn requested review from a team, jonrohan and joelhawksley August 9, 2022 19:52
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 9, 2022 19:53 Inactive
@mxriverlynn mxriverlynn changed the title updating all slot use in BorderBox to the '.with_#{slot_name}' syntax updating slot use in BorderBox examples, to show the '.with_#{slot_name}' syntax Aug 9, 2022
@mxriverlynn mxriverlynn changed the title updating slot use in BorderBox examples, to show the '.with_#{slot_name}' syntax updating slot use in BorderBox examples to the '.with_#{slot_name}' syntax Aug 9, 2022
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🎉

@mxriverlynn mxriverlynn merged commit cc81b54 into main Aug 9, 2022
@mxriverlynn mxriverlynn deleted the mxriverlynn/update-border-box-slot-examples branch August 9, 2022 20:39
@primer-css primer-css mentioned this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants