Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating label component to not always have large #1283

Merged
merged 4 commits into from
Aug 8, 2022
Merged

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Aug 8, 2022

image

https://primer.style/view-components/components/label

Currently the Label is always rendered with the Label--large class. I fixed the issue here and added a label component preview.

@jonrohan jonrohan requested review from a team and camertron August 8, 2022 19:04
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2022

🦋 Changeset detected

Latest commit: 4d132cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan temporarily deployed to github-pages August 8, 2022 19:09 Inactive
@jonrohan jonrohan enabled auto-merge (squash) August 8, 2022 19:31
@jonrohan jonrohan temporarily deployed to github-pages August 8, 2022 19:34 Inactive
@jonrohan jonrohan disabled auto-merge August 8, 2022 20:21
@jonrohan jonrohan temporarily deployed to github-pages August 8, 2022 20:26 Inactive
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) 🎉

@jonrohan jonrohan merged commit ea1c29d into main Aug 8, 2022
@jonrohan jonrohan deleted the bug_fix_label_large branch August 8, 2022 20:40
@primer-css primer-css mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants