Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Primer::DetailsComponent to Primer::Beta::Details #1280

Merged
merged 6 commits into from
Aug 11, 2022

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Aug 5, 2022

split from #676

this PR moves Primer::DetailsComponent to Primer::Beta::Details, updates all references, and replaces the original with a deprecated version

files to note

these files should be thee focus of reviews. other file changes are mostly just reference updates

screenshots

docs:
image

storybook:
image

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2022

🦋 Changeset detected

Latest commit: ff3e389

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxriverlynn mxriverlynn temporarily deployed to github-pages August 5, 2022 20:45 Inactive
@mxriverlynn mxriverlynn mentioned this pull request Aug 5, 2022
54 tasks
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 8, 2022 15:43 Inactive
@mxriverlynn mxriverlynn changed the title [WIP] Move Primer::DetailsComponent to Primer::Beta::Details Move Primer::DetailsComponent to Primer::Beta::Details Aug 8, 2022
@mxriverlynn mxriverlynn marked this pull request as ready for review August 8, 2022 15:59
@mxriverlynn mxriverlynn enabled auto-merge (squash) August 8, 2022 16:58
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 8, 2022 17:01 Inactive
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just blocking merge so we can roll out these big changes deliberately.

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for next release

@mxriverlynn mxriverlynn temporarily deployed to github-pages August 11, 2022 19:56 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 11, 2022 20:00 Inactive
@mxriverlynn mxriverlynn merged commit 1337cd4 into main Aug 11, 2022
@mxriverlynn mxriverlynn deleted the move-details-component branch August 11, 2022 20:06
@primer-css primer-css mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants