Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move Primer::CloseButton to Primer::Beta::CloseButton #1277

Merged
merged 10 commits into from
Aug 8, 2022
Merged

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Aug 4, 2022

split from #676

this PR moves the Primer::CloseButton component into the Beta:: namespace and folder, replacing the original with a deprecated version for backward compatibility.

Files to note

the following files should be the focus of code review, while the remaining files are just reference updates

screenshots

doc site:
image

storybook:
image

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022

🦋 Changeset detected

Latest commit: ecfcad8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxriverlynn mxriverlynn temporarily deployed to github-pages August 4, 2022 19:33 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 5, 2022 14:42 Inactive
@mxriverlynn mxriverlynn changed the title [WIP] move Primer::CloseButton to Primer::Beta::CloseButton move Primer::CloseButton to Primer::Beta::CloseButton Aug 5, 2022
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 5, 2022 15:11 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 5, 2022 15:16 Inactive
@mxriverlynn mxriverlynn mentioned this pull request Aug 5, 2022
54 tasks
@primer-css primer-css temporarily deployed to github-pages August 5, 2022 21:05 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 5, 2022 21:46 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 8, 2022 12:58 Inactive
@mxriverlynn mxriverlynn marked this pull request as ready for review August 8, 2022 13:05
@mxriverlynn mxriverlynn requested review from a team, jonrohan and camertron August 8, 2022 13:05
@jonrohan jonrohan enabled auto-merge (squash) August 8, 2022 16:13
@jonrohan jonrohan temporarily deployed to github-pages August 8, 2022 16:20 Inactive
@jonrohan jonrohan merged commit 59d5d6b into main Aug 8, 2022
@jonrohan jonrohan deleted the move-closebutton branch August 8, 2022 16:24
@primer-css primer-css mentioned this pull request Aug 8, 2022
jonrohan added a commit that referenced this pull request Aug 8, 2022
jonrohan added a commit that referenced this pull request Aug 8, 2022
* initial move of CloseButton to Beta::CloseButton

* added changeset

* fixed doc site nav

* docs: build docs

Co-authored-by: Actions Auto Build <actions@github.com>
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants