-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move Primer::CloseButton to Primer::Beta::CloseButton #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ecfcad8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mxriverlynn
changed the title
[WIP] move Primer::CloseButton to Primer::Beta::CloseButton
move Primer::CloseButton to Primer::Beta::CloseButton
Aug 5, 2022
54 tasks
jonrohan
approved these changes
Aug 8, 2022
Closed
jonrohan
added a commit
that referenced
this pull request
Aug 8, 2022
* initial move of CloseButton to Beta::CloseButton * added changeset * fixed doc site nav * docs: build docs Co-authored-by: Actions Auto Build <actions@github.com> Co-authored-by: Jon Rohan <yes@jonrohan.codes>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split from #676
this PR moves the
Primer::CloseButton
component into theBeta::
namespace and folder, replacing the original with a deprecated version for backward compatibility.Files to note
the following files should be the focus of code review, while the remaining files are just reference updates
screenshots
doc site:
storybook: