Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate Primer::BoxComponent to Primer::Box #1266

Merged
merged 17 commits into from
Aug 5, 2022
Merged

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Aug 2, 2022

split from #676

this PR renames Primer::BoxComponent to Primer::Box, adjusts all references to it, and adds a deprecated BoxComponent for backward compatibility. the component remains in stable status

additionally, a previous PR had a last minute change to use .to_sentence on an array of valid states. this method isn't available, so it's been changed back to a hard coded list for now.

files to note

there's a lot of files changed in this pr, but most of them are only reference changes. here are the important files to review:

screenshots

storybook page for box:
image

doc site for box:
image

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2022

🦋 Changeset detected

Latest commit: 735fccb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@primer-css primer-css temporarily deployed to github-pages August 2, 2022 21:32 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 2, 2022 21:56 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 3, 2022 01:40 Inactive
@mxriverlynn mxriverlynn mentioned this pull request Aug 3, 2022
54 tasks
@mxriverlynn mxriverlynn changed the title [WIP] migrate Primer::BoxComponent to Primer::Box migrate Primer::BoxComponent to Primer::Box Aug 3, 2022
@mxriverlynn mxriverlynn marked this pull request as ready for review August 3, 2022 13:11
@mxriverlynn mxriverlynn requested review from a team and jonrohan August 3, 2022 13:11
@mxriverlynn mxriverlynn enabled auto-merge (squash) August 3, 2022 13:11
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 3, 2022 19:40 Inactive
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I just want to make sure we space it out in releases between other renames like it so we don't have too many migrations at once in github/github.

Blocking so we don't accidentally add it to a release when we're not ready

@mxriverlynn mxriverlynn temporarily deployed to github-pages August 3, 2022 21:30 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 4, 2022 14:18 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 4, 2022 14:47 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 4, 2022 18:39 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages August 5, 2022 14:42 Inactive
@jonrohan jonrohan temporarily deployed to github-pages August 5, 2022 17:41 Inactive
@mxriverlynn mxriverlynn merged commit 7d2949d into main Aug 5, 2022
@mxriverlynn mxriverlynn deleted the move-box-component branch August 5, 2022 17:46
@primer-css primer-css mentioned this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants