copy JS to static docs directory and use that instead #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
khiga8
force-pushed
the
kh-copy-js-to-docs
branch
from
fcc3c9e
to
1f650ee
Compare
camertron
approved these changes
Aug 1, 2022
| @@ -26,7 +26,7 @@ | |||
| "scripts": { | |||
| "build:docs": "cd docs && yarn gatsby build --prefix-paths", | |||
| "build:docs:preview": "cd docs && yarn gatsby build", | |||
| "prepare": "tsc && rollup -c", | |||
| "prepare": "rm -rf docs/static && mkdir docs/static && tsc && rollup -c && cp app/assets/javascripts/primer_view_components.js docs/static/primer_view_components.js", | |||
There was a problem hiding this comment.
Is there anything else in docs/static that this command is blowing away?
There was a problem hiding this comment.
Nope, this is a new directory!
This was referenced Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix:
Currently I'm unable to share a documentation site with my JS changes because the docs preview and codespaces both pull in the published JS package in npm rather than the changes on my branch.
This means even when code is merged, people are unable to see JS changes on the docs site until a new PVC release is cut which is not ideal since the JS on the docs site should reflect whats in the codebase.
This is a workaround I used in the past but I'm not sure it's actually what we want.