Consolidating view_components previews into test/previews/ folder #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a80b931 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joelhawksley
approved these changes
Jul 27, 2022
jonrohan
changed the title
This reverts commit 3ebf573.
Merged
krhkt
pushed a commit
that referenced
this pull request
Sep 1, 2022
) * Adding test/components/previews folder to app config * Moving demo/test/component/previews * Fixing rubocop issues * Fixing flash preview * Combining duplicate previews * Fixing tooltip test * Fixing underline panels test * Fixing tab panels test * Fixing autocomplete test * Fixing remaining integration tests * Move to root test/previews/ * move it out of previews folder * always create system test * Revert "move it out of previews folder" This reverts commit 3ebf573. * Create loud-tips-fold.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to consolidate new lookbook VC previews with the system related tests added for JS components.
I wanted to simplify our previews here and tests. This will open us to writing tests with
render_previewfrom VC.What it does:
demo/test/components/previewstotest/previews