Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role to system args docs #1179

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Conversation

maxbeizer
Copy link
Contributor

Role was not included in the system args docs. @joelhawksley confirmed that it does indeed function as a system arg, so this adds it to the docs.

I figured a link to MDN would be better than enumerating all the roles. WDYT?

@maxbeizer maxbeizer requested review from a team and camertron May 31, 2022 21:22
@changeset-bot
Copy link

changeset-bot bot commented May 31, 2022

🦋 Changeset detected

Latest commit: 084f04c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan enabled auto-merge (squash) June 1, 2022 03:15
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks!

@jonrohan jonrohan merged commit aa7afef into primer:main Jun 1, 2022
@primer-css primer-css mentioned this pull request Jun 1, 2022
@maxbeizer
Copy link
Contributor Author

Thanks @jonrohan !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants