Autocomplete design updates #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e65af60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
…er/view_components into autocomplete-design-updates
… autocomplete-design-updates
…er/view_components into autocomplete-design-updates
…er/view_components into autocomplete-design-updates
langermank
commented
May 26, 2022
camertron
requested changes
May 26, 2022
app/components/primer/beta/auto_complete/auto_complete.html.erb
Outdated
Show resolved
Hide resolved
| @@ -3,3 +3,6 @@ | |||
| /* @import '/workspaces/css/src/index.scss'; */ | |||
|
|
|||
| @import '@primer/css/index.scss'; | |||
|
|
|||
| /* temporary design token imports */ | |||
| @import '@primer/css/primitives/index.scss'; | |||
There was a problem hiding this comment.
Does this need to be removed now?
Co-authored-by: Cameron Dutro <camertron@gmail.com>
Co-authored-by: Cameron Dutro <camertron@gmail.com>
Co-authored-by: Cameron Dutro <camertron@gmail.com>
Co-authored-by: Cameron Dutro <camertron@gmail.com>
camertron
approved these changes
May 26, 2022
jonrohan
reviewed
May 26, 2022
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These markup and CSS changes bring the Autocomplete component in closer alignment with PRC and design. This PR depends on a PCSS release, and is currently attached to a pre-release.
OverlayandActionListfor the picker stylesFormControlstyles to align with the upcoming Forms work (and to align with PRC).To test, open this PR in a codespace and run
script/lookbookfrom root.Closes https://github.com/github/primer/issues/796