Skip to content

Commit

Permalink
Merge branch 'main' into refactor-dialog-to-use-dialog-internally
Browse files Browse the repository at this point in the history
  • Loading branch information
keithamus authored Nov 15, 2023
2 parents 21e06a0 + 97f0339 commit c8ac2f5
Show file tree
Hide file tree
Showing 22 changed files with 310 additions and 647 deletions.
5 changes: 5 additions & 0 deletions .changeset/popular-timers-shop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/view-components': minor
---

Remove touch target gaps between ActionBar items
5 changes: 5 additions & 0 deletions .changeset/soft-singers-travel.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/view-components': minor
---

Add missing 64px Avatar size
10 changes: 5 additions & 5 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,21 @@ updates:
- "skip changeset"
- "actions"
schedule:
interval: "monthly"
interval: "weekly"

# NPM
- package-ecosystem: "npm"
directory: "/"
schedule:
interval: "monthly"
interval: "weekly"
labels:
- "dependencies"
- "skip changeset"
- "npm"
- package-ecosystem: "npm"
directory: "/demo"
schedule:
interval: "monthly"
interval: "weekly"
labels:
- "dependencies"
- "skip changeset"
Expand All @@ -34,15 +34,15 @@ updates:
- package-ecosystem: "bundler"
directory: "/"
schedule:
interval: "monthly"
interval: "weekly"
labels:
- "dependencies"
- "skip changeset"
- "bundler"
- package-ecosystem: "bundler"
directory: "/demo"
schedule:
interval: "monthly"
interval: "weekly"
labels:
- "dependencies"
- "skip changeset"
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- uses: actions/checkout@v4
- name: Get specific changed files
id: changed-files
uses: tj-actions/changed-files@v40.0.2
uses: tj-actions/changed-files@v40.1.1
with:
files: |
docs/**/*.md
Expand All @@ -39,7 +39,7 @@ jobs:
- uses: actions/checkout@v4
- name: Get specific changed files
id: changed-files
uses: tj-actions/changed-files@v40.0.2
uses: tj-actions/changed-files@v40.1.1
with:
files: |
app/**/*.rb
Expand All @@ -62,7 +62,7 @@ jobs:
- uses: actions/checkout@v4
- name: Get changed files
id: changed-files
uses: tj-actions/changed-files@v40.0.2
uses: tj-actions/changed-files@v40.1.1
with:
files: |
app/components/**/*.erb
Expand All @@ -82,7 +82,7 @@ jobs:
- uses: actions/checkout@v4
- name: Get changed files
id: changed-files
uses: tj-actions/changed-files@v40.0.2
uses: tj-actions/changed-files@v40.1.1
with:
files: |
app/components/**/*.ts
Expand All @@ -103,7 +103,7 @@ jobs:
- uses: actions/checkout@v4
- name: Get changed files
id: changed-files
uses: tj-actions/changed-files@v40.0.2
uses: tj-actions/changed-files@v40.1.1
with:
files: |
app/components/**/*.pcss
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-checklist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

- name: Get or Create Comment
if: success() && steps.findPr.outputs.number
uses: actions/github-script@v6
uses: actions/github-script@v7
env:
PR_NUMBER: ${{ steps.findPr.outputs.pr }}
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
name: semver label
runs-on: ubuntu-latest
steps:
- uses: actions/github-script@v6
- uses: actions/github-script@v7
id: version-result
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"
Expand All @@ -60,7 +60,7 @@ jobs:
if (match && match[0]) {
return match[0][1]
}
- uses: actions/github-script@v6
- uses: actions/github-script@v7
env:
RELEASE: ${{ steps.version-result.outputs.result }}
with:
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 1 addition & 17 deletions app/components/primer/alpha/action_bar.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
.ActionBar {
position: relative;
display: flex !important;
min-width: calc(var(--control-medium-size) * 3);
min-width: calc(var(--control-medium-size) * 3);
align-items: center;
flex-grow: 1;
flex-shrink: 1;
Expand Down Expand Up @@ -51,19 +51,3 @@
.ActionBar--large .ActionBar-divider {
margin: 0 var(--controlStack-large-gap-condensed);
}

/* Increase spacing so touch targets don't overlap */

@media (pointer: coarse) {
.ActionBar .ActionBar-item-container {
gap: calc(var(--control-minTarget-coarse) - var(--control-medium-size)); /* 12px */
}

.ActionBar--small .ActionBar-item-container {
gap: calc(var(--control-minTarget-coarse) - var(--control-small-size)); /* 16px */
}

.ActionBar--large .ActionBar-item-container {
gap: calc(var(--control-minTarget-coarse) - var(--control-large-size)); /* 4px */
}
}
2 changes: 1 addition & 1 deletion app/components/primer/beta/avatar.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class Avatar < Primer::Component
DEFAULT_SHAPE = :circle
SHAPE_OPTIONS = [DEFAULT_SHAPE, :square].freeze

SIZE_OPTIONS = [16, DEFAULT_SIZE, SMALL_THRESHOLD, 32, 40, 48, 80].freeze
SIZE_OPTIONS = [16, DEFAULT_SIZE, SMALL_THRESHOLD, 32, 40, 48, 64, 80].freeze

# @param src [String] The source url of the avatar image.
# @param alt [String] Passed through to alt on img tag.
Expand Down
28 changes: 14 additions & 14 deletions demo/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions demo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"dependencies": {
"@primer/css": "^21.0.9",
"@primer/primitives": "^7.15.0",
"@rails/actioncable": "^7.1.1",
"@rails/ujs": "^7.1.1",
"@rails/actioncable": "^7.1.2",
"@rails/ujs": "^7.1.2",
"turbolinks": "^5.2.0",
"webpack-dev-server": "^4.15.1"
}
Expand Down
Loading

0 comments on commit c8ac2f5

Please sign in to comment.