Fixing whitespace in rendered LinkComponent (#1274)

* Fixing whitespace in rendered link

* Create brave-planets-reply.md

.changeset/brave-planets-reply.md

@@ -0,0 +1,5 @@
+---
+"@primer/view-components": patch
+---
+
+Fixing whitespace in rendered LinkComponent

app/components/primer/link_component.rb

@@ -79,5 +79,19 @@ def initialize(href: nil, tag: DEFAULT_TAG, scheme: DEFAULT_SCHEME, muted: false
     def before_render
       raise ArgumentError, "href is required when using <a> tag" if @system_arguments[:tag] == :a && @system_arguments[:href].nil? && !Rails.env.production?
     end
+
+    def call
+      if tooltip.present?
+        render Primer::BaseComponent.new(tag: :span, position: :relative) do
+          render(Primer::BaseComponent.new(**@system_arguments)) do
+            content
+          end.to_s + tooltip.to_s
+        end
+      else
+        render(Primer::BaseComponent.new(**@system_arguments)) do
+          content
+        end
+      end
+    end
   end
 end

test/components/link_component_test.rb

@@ -13,9 +13,9 @@ def test_renders_content_and_not_muted_link
   end
 
   def test_renders_no_additional_whitespace
-    render_inline(Primer::LinkComponent.new(href: "http://joe-jonas-shirtless.com")) { "content" }
+    result = render_inline(Primer::LinkComponent.new(href: "http://joe-jonas-shirtless.com")) { "content" }
 
-    assert_text(/^content$/)
+    assert_match(%r{^<a[^>]+>content</a>$}, result.to_s)
   end
 
   def test_renders_without_trailing_newline
@@ -83,4 +83,13 @@ def test_raises_if_a_tag_and_href_nil
   def test_status
     assert_component_state(Primer::LinkComponent, :beta)
   end
+
+  def test_renders_with_tooltip_sibling
+    render_inline(Primer::LinkComponent.new(id: "1", href: "http://google.com")) do |c|
+      c.tooltip(text: "Tooltip text")
+      "content"
+    end
+
+    assert_selector("a[href='http://google.com'] + tool-tip", text: "Tooltip text", visible: false)
+  end
 end