Get attribute from trigger button and not event target (#1484)

Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com> Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
primer · Oct 12, 2022 · ac33b43 · ac33b43
1 parent a4743fd
commit ac33b43
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/app/components/primer/alpha/modal_dialog.ts b/app/components/primer/alpha/modal_dialog.ts
@@ -14,11 +14,11 @@ function clickHandler(event: Event) {
   const button = target?.closest('button')
 
   // If the user is clicking a valid dialog trigger
-  let dialogId = target.getAttribute('data-show-dialog-id')
-  if (target instanceof HTMLButtonElement && dialogId) {
+  let dialogId = button?.getAttribute('data-show-dialog-id')
+  if (button && dialogId) {
     event.stopPropagation()
-    const dialog = document.querySelector<ModalDialogElement>(`#${dialogId}`)
-    if (dialog) {
+    const dialog = document.getElementById(dialogId)
+    if (dialog instanceof ModalDialogElement) {
       dialog.openButton = button
       dialog.show()
       return