Skip to content

Commit

Permalink
Don't export web components (#1560)
Browse files Browse the repository at this point in the history
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
  • Loading branch information
safeforge and keithamus authored Nov 1, 2022
1 parent d437184 commit 8bc7d1c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/dull-rabbits-glow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/view-components': patch
---

Avoid double-registering of exported components
2 changes: 1 addition & 1 deletion app/components/primer/alpha/segmented_control.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {controller, targets} from '@github/catalyst'

@controller
export class SegmentedControlElement extends HTMLElement {
class SegmentedControlElement extends HTMLElement {
@targets items: HTMLElement[]

connectedCallback() {
Expand Down
2 changes: 1 addition & 1 deletion app/components/primer/beta/x_banner.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {controller, target} from '@github/catalyst'

@controller
export class XBannerElement extends HTMLElement {
class XBannerElement extends HTMLElement {
@target root: HTMLElement
@target titleText: HTMLElement

Expand Down

0 comments on commit 8bc7d1c

Please sign in to comment.