Allow consumers to set ActionList item content's tag (#1880)

primer · Mar 11, 2023 · 7a160a4 · 7a160a4
1 parent b3b94e9
commit 7a160a4
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 6 deletions.
diff --git a/.changeset/chilled-mugs-play.md b/.changeset/chilled-mugs-play.md
@@ -0,0 +1,5 @@
+---
+'@primer/view-components': patch
+---
+
+Allow consumers to set ActionList item content's tag
diff --git a/app/components/primer/alpha/action_list/item.rb b/app/components/primer/alpha/action_list/item.rb
@@ -212,12 +212,14 @@ def initialize(
             SIZE_MAPPINGS[@size]
           )
 
-          if @href && !@disabled
-            @content_arguments[:tag] = :a
-            @content_arguments[:href] = @href
-          else
-            @content_arguments[:tag] = :button
-            @content_arguments[:onclick] = on_click if on_click
+          unless @content_arguments[:tag]
+            if @href && !@disabled
+              @content_arguments[:tag] = :a
+              @content_arguments[:href] = @href
+            else
+              @content_arguments[:tag] = :button
+              @content_arguments[:onclick] = on_click if on_click
+            end
           end
 
           @description_wrapper_arguments = {

diff --git a/test/components/alpha/action_list_test.rb b/test/components/alpha/action_list_test.rb
@@ -109,6 +109,14 @@ def test_manual_dividers
           { type: :item, href: "/item3" }
         ]
       end
+
+      def test_allows_custom_item_tag
+        render_inline(Primer::Alpha::ActionList.new(aria: { label: "List" })) do |component|
+          component.with_item(label: "Item 1", content_arguments: { tag: :"clipboard-copy" })
+        end
+
+        assert_selector "clipboard-copy.ActionListContent"
+      end
     end
   end
 end