Skip to content

Commit

Permalink
Delete Primer::Alpha::ImageCrop (#3158)
Browse files Browse the repository at this point in the history
  • Loading branch information
jonrohan authored Oct 18, 2024
1 parent 5bc179d commit 683abd2
Show file tree
Hide file tree
Showing 15 changed files with 5 additions and 284 deletions.
5 changes: 5 additions & 0 deletions .changeset/afraid-teachers-battle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/view-components": minor
---

Delete Primer::Alpha::ImageCrop
12 changes: 0 additions & 12 deletions app/components/primer/alpha/image_crop.html.erb

This file was deleted.

28 changes: 0 additions & 28 deletions app/components/primer/alpha/image_crop.rb

This file was deleted.

1 change: 0 additions & 1 deletion app/components/primer/alpha/image_crop.ts

This file was deleted.

1 change: 0 additions & 1 deletion app/components/primer/primer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import './focus_group'
import './scrollable_region'
import './aria_live'
import './shared_events'
import './alpha/image_crop'
import './alpha/modal_dialog'
import './beta/nav_list'
import './beta/nav_list_group_element'
Expand Down
1 change: 0 additions & 1 deletion lib/primer/yard/component_manifest.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ class ComponentManifest
Primer::Alpha::HellipButton => {},
Primer::Alpha::Image => {},
Primer::Alpha::OcticonSymbols => {},
Primer::Alpha::ImageCrop => { js: true },
Primer::IconButton => { js: true },
Primer::Beta::AutoComplete => { js: true },
Primer::Beta::AutoComplete::Item => {},
Expand Down
31 changes: 0 additions & 31 deletions previews/primer/alpha/image_crop_preview.rb

This file was deleted.

28 changes: 0 additions & 28 deletions static/arguments.json
Original file line number Diff line number Diff line change
Expand Up @@ -1351,34 +1351,6 @@
}
]
},
{
"component": "ImageCrop",
"status": "alpha",
"a11y_reviewed": false,
"short_name": "ImageCrop",
"source": "https://github.com/primer/view_components/tree/main/app/components/primer/alpha/image_crop.rb",
"lookbook": "https://primer.style/view-components/lookbook/inspect/primer/alpha/image_crop/default/",
"parameters": [
{
"name": "src",
"type": "String",
"default": "N/A",
"description": "The path of the image to crop."
},
{
"name": "rounded",
"type": "Boolean",
"default": "`true`",
"description": "If the crop mask should be a circle. Defaults to true."
},
{
"name": "system_arguments",
"type": "Hash",
"default": "N/A",
"description": "[System arguments](/system-arguments)"
}
]
},
{
"component": "Layout",
"status": "alpha",
Expand Down
1 change: 0 additions & 1 deletion static/audited_at.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"Primer::Alpha::HellipButton": "",
"Primer::Alpha::HiddenTextExpander": "",
"Primer::Alpha::Image": "",
"Primer::Alpha::ImageCrop": "",
"Primer::Alpha::Layout": "",
"Primer::Alpha::Layout::Main": "",
"Primer::Alpha::Layout::Sidebar": "",
Expand Down
2 changes: 0 additions & 2 deletions static/constants.json
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,6 @@
},
"Primer::Alpha::Image": {
},
"Primer::Alpha::ImageCrop": {
},
"Primer::Alpha::Layout": {
"FIRST_IN_SOURCE_DEFAULT": "sidebar",
"FIRST_IN_SOURCE_OPTIONS": [
Expand Down
95 changes: 0 additions & 95 deletions static/info_arch.json
Original file line number Diff line number Diff line change
Expand Up @@ -4620,101 +4620,6 @@

]
},
{
"fully_qualified_name": "Primer::Alpha::ImageCrop",
"description": "A client-side mechanism to crop images.",
"accessibility_docs": null,
"is_form_component": false,
"is_published": true,
"requires_js": true,
"component": "ImageCrop",
"status": "alpha",
"a11y_reviewed": false,
"short_name": "ImageCrop",
"source": "https://github.com/primer/view_components/tree/main/app/components/primer/alpha/image_crop.rb",
"lookbook": "https://primer.style/view-components/lookbook/inspect/primer/alpha/image_crop/default/",
"parameters": [
{
"name": "src",
"type": "String",
"default": "N/A",
"description": "The path of the image to crop."
},
{
"name": "rounded",
"type": "Boolean",
"default": "`true`",
"description": "If the crop mask should be a circle. Defaults to true."
},
{
"name": "system_arguments",
"type": "Hash",
"default": "N/A",
"description": "{{link_to_system_arguments_docs}}"
}
],
"slots": [
{
"name": "loading",
"description": "A loading indicator that is shown while the image is loading.",
"parameters": [
{
"name": "system_arguments",
"type": "Hash",
"default": "N/A",
"description": "{{link_to_system_arguments_docs}}"
}
]
}
],
"methods": [

],
"previews": [
{
"preview_path": "primer/alpha/image_crop/playground",
"name": "playground",
"snapshot": "false",
"skip_rules": {
"wont_fix": [
"region"
],
"will_fix": [
"color-contrast"
]
}
},
{
"preview_path": "primer/alpha/image_crop/default",
"name": "default",
"snapshot": "false",
"skip_rules": {
"wont_fix": [
"region"
],
"will_fix": [
"color-contrast"
]
}
},
{
"preview_path": "primer/alpha/image_crop/loading",
"name": "loading",
"snapshot": "false",
"skip_rules": {
"wont_fix": [
"region"
],
"will_fix": [
"color-contrast"
]
}
}
],
"subcomponents": [

]
},
{
"fully_qualified_name": "Primer::Alpha::Layout",
"description": "`Layout` provides foundational patterns for responsive pages.\n`Layout` can be used for simple two-column pages, or it can be nested to provide flexible 3-column experiences.\n On smaller screens, `Layout` uses vertically stacked rows to display content.\n\n`Layout` flows as both column, when there's enough horizontal space to render both `Main` and `Sidebar`side-by-side (on a desktop of tablet device, per instance);\nor it flows as a row, when `Main` and `Sidebar` are stacked vertically (e.g. on a mobile device).\n`Layout` should always work in any screen size.",
Expand Down
47 changes: 0 additions & 47 deletions static/previews.json
Original file line number Diff line number Diff line change
Expand Up @@ -3978,53 +3978,6 @@
}
]
},
{
"name": "image_crop",
"component": "ImageCrop",
"status": "alpha",
"lookup_path": "primer/alpha/image_crop",
"examples": [
{
"preview_path": "primer/alpha/image_crop/playground",
"name": "playground",
"snapshot": "false",
"skip_rules": {
"wont_fix": [
"region"
],
"will_fix": [
"color-contrast"
]
}
},
{
"preview_path": "primer/alpha/image_crop/default",
"name": "default",
"snapshot": "false",
"skip_rules": {
"wont_fix": [
"region"
],
"will_fix": [
"color-contrast"
]
}
},
{
"preview_path": "primer/alpha/image_crop/loading",
"name": "loading",
"snapshot": "false",
"skip_rules": {
"wont_fix": [
"region"
],
"will_fix": [
"color-contrast"
]
}
}
]
},
{
"name": "label",
"component": "Label",
Expand Down
1 change: 0 additions & 1 deletion static/statuses.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"Primer::Alpha::HellipButton": "alpha",
"Primer::Alpha::HiddenTextExpander": "alpha",
"Primer::Alpha::Image": "alpha",
"Primer::Alpha::ImageCrop": "alpha",
"Primer::Alpha::Layout": "alpha",
"Primer::Alpha::Layout::Main": "alpha",
"Primer::Alpha::Layout::Sidebar": "alpha",
Expand Down
35 changes: 0 additions & 35 deletions test/components/alpha/image_crop_test.rb

This file was deleted.

1 change: 0 additions & 1 deletion test/components/component_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ class PrimerComponentTest < Minitest::Test
[Primer::Alpha::TabNav, { label: "label" }],
[Primer::Alpha::UnderlinePanels, { label: "Panel label" }],
[Primer::Alpha::Image, { src: "https://github.com/github.png", alt: "alt" }],
[Primer::Alpha::ImageCrop, { src: "Foo" }],
[Primer::IconButton, { icon: :star, "aria-label": "Label" }],
[Primer::Alpha::ActionList, { aria: { label: "Action List" } }, lambda do |component|
component.with_item(label: "Foo")
Expand Down

0 comments on commit 683abd2

Please sign in to comment.