Add min-width to small size Button (#2821)

Co-authored-by: khiga8 <khiga8@users.noreply.github.com> Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
primer · Apr 30, 2024 · 19f4d7e · 19f4d7e
1 parent 1863522
commit 19f4d7e
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 0 deletions.
diff --git a/.changeset/brown-rocks-drive.md b/.changeset/brown-rocks-drive.md
@@ -0,0 +1,5 @@
+---
+"@primer/view-components": patch
+---
+
+Add min-width
diff --git a/...ots.test.ts-snapshots/primer/beta/button/small_scheme_one_character/default.png b/...ots.test.ts-snapshots/primer/beta/button/small_scheme_one_character/default.png
diff --git a/...ots.test.ts-snapshots/primer/beta/button/small_scheme_one_character/focused.png b/...ots.test.ts-snapshots/primer/beta/button/small_scheme_one_character/focused.png
diff --git a/app/components/primer/beta/button.pcss b/app/components/primer/beta/button.pcss
@@ -128,6 +128,7 @@ summary.Button {
   height: var(--control-small-size);
   padding: 0 var(--control-small-paddingInline-condensed);
   gap: var(--control-small-gap);
+  min-width: var(--control-small-size);
 
   & .Button-label {
     line-height: var(--text-body-lineHeight-small);

diff --git a/previews/primer/beta/button_preview.rb b/previews/primer/beta/button_preview.rb
@@ -414,6 +414,12 @@ def inactive(
       def link_scheme_label_wrap
         render_with_template(locals: {})
       end
+
+      # @label Small scheme with one character
+      # @snapshot
+      def small_scheme_one_character
+        render_with_template(locals: {})
+      end
     end
   end
 end
diff --git a/previews/primer/beta/button_preview/small_scheme_one_character.html.erb b/previews/primer/beta/button_preview/small_scheme_one_character.html.erb
@@ -0,0 +1,5 @@
+<%= render(Primer::Beta::Button.new(
+    size: :small,
+)) do %>
+  i
+<% end %>