Skip to content

Conversation

mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Sep 30, 2025

Relates to https://github.com/github/primer/issues/5424 and https://github.com/github/primer/issues/5828

Changelog

New

Changed

Removed

Removes sx prop from FormControl.Label and internal text input-related components

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@mperrotti mperrotti requested a review from a team as a code owner September 30, 2025 21:16
Copy link

changeset-bot bot commented Sep 30, 2025

🦋 Changeset detected

Latest commit: fe5808f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes dependencies on BoxWithFallback and the sx prop from InputLabel and UnstyledTextInput components as part of the migration away from styled-system. The changes simplify these internal components by using native elements directly instead of the abstraction layer.

  • Removes SxProp and sx parameter support from both components
  • Replaces BoxWithFallback usage with direct native element rendering
  • Updates type definitions to use modern polymorphic patterns for InputLabel

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/internal/components/UnstyledTextInput.tsx Removes SxProp import and BoxWithFallback usage, returns native input element directly
packages/react/src/internal/components/InputLabel.tsx Removes SxProp and BoxWithFallback, implements modern polymorphic typing and direct element rendering

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 30, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-6929 September 30, 2025 21:21 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6929 September 30, 2025 21:29 Inactive
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to storybook-preview-6929 October 1, 2025 13:08 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 1, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-6929 October 6, 2025 19:31 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6929 October 6, 2025 19:39 Inactive
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3919

@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 6, 2025
Copy link
Contributor

github-actions bot commented Oct 6, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 6, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6929 October 6, 2025 23:30 Inactive
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 7, 2025
Copy link
Contributor

github-actions bot commented Oct 7, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants