-
Notifications
You must be signed in to change notification settings - Fork 638
Remove BoxWithFallback usage and sx
prop from InputLabel and UnstyledTextInput
#6929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: fe5808f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes dependencies on BoxWithFallback and the sx
prop from InputLabel and UnstyledTextInput components as part of the migration away from styled-system. The changes simplify these internal components by using native elements directly instead of the abstraction layer.
- Removes
SxProp
andsx
parameter support from both components - Replaces
BoxWithFallback
usage with direct native element rendering - Updates type definitions to use modern polymorphic patterns for InputLabel
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/react/src/internal/components/UnstyledTextInput.tsx | Removes SxProp import and BoxWithFallback usage, returns native input element directly |
packages/react/src/internal/components/InputLabel.tsx | Removes SxProp and BoxWithFallback, implements modern polymorphic typing and direct element rendering |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
….com:primer/react into mp/rm-boxwithfallback-internal-input-helpers
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3919 |
🟢 ci completed with status |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
Relates to https://github.com/github/primer/issues/5424 and https://github.com/github/primer/issues/5828
Changelog
New
Changed
Removed
Removes
sx
prop fromFormControl.Label
and internal text input-related componentsRollout strategy
Testing & Reviewing
Merge checklist