Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving CSS component feature flag for multiple components from team to staff #5610

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

jonrohan
Copy link
Member

Changelog

New

Changed

These changes shouldn't effect production in integration testing. Validate there's no current bugs with any of these components before migrating.

  • Moving CSS component feature flag for Autocomplete from team to staff
  • Moving CSS component feature flag for AvatarStack from team to staff
  • Moving CSS component feature flag for BaseStyles from team to staff
  • Moving CSS component feature flag for ConfirmationDialog from team to staff
  • Moving CSS component feature flag for DataTable from team to staff
  • Moving CSS component feature flag for Hidden from team to staff
  • Moving CSS component feature flag for InlineMessage from team to staff
  • Moving CSS component feature flag for KeybindingHint from team to staff
  • Moving CSS component feature flag for NavList from team to staff
  • Moving CSS component feature flag for Overlay from team to staff
  • Moving CSS component feature flag for PageHeader from team to staff
  • Moving CSS component feature flag for PageLayout from team to staff
  • Moving CSS component feature flag for Pagination from team to staff
  • Moving CSS component feature flag for SegmentedControl from team to staff
  • Moving CSS component feature flag for SelectPanel from team to staff
  • Moving CSS component feature flag for SideNav from team to staff
  • Moving CSS component feature flag for SubNav from team to staff
  • Moving CSS component feature flag for Token from team to staff
  • Moving CSS component feature flag for TooltipV2 from team to staff
  • Moving CSS component feature flag for UnderlinePanels from team to staff
  • Moving CSS component feature flag for UnderlineTabbedInterface from team to staff

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner January 27, 2025 21:34
@jonrohan jonrohan requested a review from camertron January 27, 2025 21:34
Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: 882dd10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 27, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5610 January 27, 2025 21:37 Inactive
Copy link
Contributor

github-actions bot commented Jan 27, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.42 KB (+0.01% 🔺)
packages/react/dist/browser.umd.js 104.73 KB (-0.15% 🔽)

@jonrohan jonrohan requested review from francinelucca and removed request for camertron January 27, 2025 21:39
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonrohan jonrohan enabled auto-merge January 27, 2025 23:32
@jonrohan jonrohan added this pull request to the merge queue Jan 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2025
@jonrohan jonrohan added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 32b1f2f Jan 28, 2025
42 of 43 checks passed
@jonrohan jonrohan deleted the move_primer_team_css_module_flags branch January 28, 2025 00:07
@primer primer bot mentioned this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants