-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(useResizeObserver): undefined variable alternative #5595
Conversation
🦋 Changeset detectedLatest commit: ecbf35c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 Looks like there might be a few cases where we don't need to check for null
/undefined
tho?
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/359330 |
🟢 golden-jobs completed with status |
Closes https://github.com/github/primer/issues/4685
We were seeing a small number of errors for undefined
ResizeObserver
, introducing a check for whenResizeObserver
is not defined and using a manual solution instead.Changelog
Changed
Rollout strategy
Testing & Reviewing
Merge checklist