Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide NavList sub items if collapsed #5567

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Hide NavList sub items if collapsed #5567

merged 3 commits into from
Jan 21, 2025

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Jan 17, 2025 •
edited
Loading

Closes https://github.com/github/primer/issues/4684

Changelog

Cute lil one liner

If anyone has a suggestion for how I can add a VRT test showing a collapsed NavList, I'd appreciate it!

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 524e162

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5567 January 17, 2025 21:30 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.25 KB (0%)
packages/react/dist/browser.umd.js 104.56 KB (0%)

@langermank langermank marked this pull request as ready for review January 17, 2025 23:35
@langermank langermank requested a review from a team as a code owner January 17, 2025 23:35
@langermank langermank requested a review from jonrohan January 17, 2025 23:35
mperrotti
mperrotti approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@mperrotti mperrotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this fix in primer-docs, and it works

@langermank langermank added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 8bdff77 Jan 21, 2025
42 checks passed
@langermank langermank deleted the navlist-fix branch January 21, 2025 19:57
@primer primer bot mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mperrotti mperrotti mperrotti approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @mperrotti