Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination: Accessibility enhancements #5488

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

hectahertz
Copy link
Contributor

@hectahertz hectahertz commented Jan 3, 2025

Changelog

New

Makes the default <Pagination/> story interactive:

interactive.mov

Changed

Hides the <Pagination/> Previous and Next buttons from the accessibility tree when they are disabled, as they are non functional.
Accessibility tree on Chrome devtools showing aria-hidden
Accessibility tree on Chrome devtools showing aria-hidden

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Things to review:

  • Logic of the status update on the Default example.
  • SR behavior concerning the Previous and Next buttons

Merge checklist

@hectahertz hectahertz requested a review from a team as a code owner January 3, 2025 16:15
Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: 4dc4fbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This comment was marked as resolved.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5488 January 3, 2025 16:17 Inactive
Copy link
Contributor

github-actions bot commented Jan 3, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.17 KB (-0.09% 🔽)
packages/react/dist/browser.umd.js 104.65 KB (+0.01% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5488 January 3, 2025 16:27 Inactive
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FYI we have a VRT issue on main we're investigating, so these failures are probably not related to your PR

@hectahertz hectahertz added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit e352e19 Jan 7, 2025
42 checks passed
@hectahertz hectahertz deleted the hectahertz/pagination-a11y-enhancements branch January 7, 2025 17:03
@primer primer bot mentioned this pull request Jan 7, 2025
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/357068

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 9, 2025
francinelucca added a commit that referenced this pull request Jan 9, 2025
francinelucca added a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants