Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update figma code connect dependency #5454

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lukasoppermann
Copy link
Contributor

Update figma code connect dependency

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@lukasoppermann lukasoppermann requested a review from a team as a code owner December 18, 2024 12:57
Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: ea2fd6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 18, 2024
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@lukasoppermann lukasoppermann added the skip changeset This change does not need a changelog label Dec 18, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5454 December 18, 2024 13:00 Inactive
Copy link
Contributor

github-actions bot commented Dec 18, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.7 KB (0%)
packages/react/dist/browser.umd.js 104.15 KB (0%)

Comment on lines +84 to +86
"overrides": {
"nwsapi": "2.2.2"
},
Copy link
Contributor

@TylerJDev TylerJDev Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to utilize an override here, as there's a problem with the latest version of nwsapi and the :has selector (some context), which causes some tests to fail (such as TreeView.test.tsx), since there's usage of :has in some selectors.

When this is resolved we can remove it, but for now it's needed in order for us to bump @figma/code-connect.

@lukasoppermann
Copy link
Contributor Author

Works perfect @TylerJDev, could you approve the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants