Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Hidden): Convert Hidden to CSS modules behind feature flag #5403

Merged
merged 3 commits into from
Dec 11, 2024
Merged

feat(Hidden): Convert Hidden to CSS modules behind feature flag #5403

merged 3 commits into from
Dec 11, 2024

Conversation

JelloBagel
Copy link
Contributor

@JelloBagel JelloBagel commented Dec 9, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/4133

Changelog

Changed

  • Convert Hidden to CSS modules behind primer_react_css_modules_team feature flag

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c5bd189

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5403 December 9, 2024 20:10 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.32 KB (0%)
packages/react/dist/browser.umd.js 102.81 KB (0%)

JelloBagel
JelloBagel commented Dec 9, 2024
View reviewed changes
packages/react/src/Hidden/Hidden.tsx
// Get breakpoint declarations for the normalized ResponsiveValue object
const styles = getBreakpointDeclarations(normalize(when), 'display', () => 'none')
// Render the children with the styles
return styles ? <Box sx={styles}>{children}</Box> : null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styles was always an object so I removed the check here

packages/react/src/Hidden/Hidden.tsx
/* Normalize the value that is received from the prop `when`.
* For array types : ['narrow', 'wide'] -> {narrow: true, wide: true}
* For string types: 'narrow' -> {narrow: true}
*/
function normalize(hiddenViewports: Array<Viewport> | Viewport): ResponsiveValue<boolean> | null {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normalize method always returns an object

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/354267

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 9, 2024
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Dec 9, 2024
@JelloBagel JelloBagel marked this pull request as ready for review December 9, 2024 23:53
@JelloBagel JelloBagel requested a review from a team as a code owner December 9, 2024 23:53
@JelloBagel JelloBagel requested a review from camertron December 9, 2024 23:53
@JelloBagel JelloBagel added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 877497c Dec 11, 2024
43 checks passed
@JelloBagel JelloBagel deleted the jellobagel-hidden-cssmodules branch December 11, 2024 18:48
@primer primer bot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@camertron camertron Awaiting requested review from camertron camertron is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelloBagel @jonrohan