Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(Overlay): Add default and playground story #5245

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

francinelucca
Copy link
Member

Closes #5183

Changelog

New

  • Default & Playground Overlay story

Changed

  • Refactor default SB sorting to use same sorting as Components in Experimental, Deprecated and Private

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link
Contributor

github-actions bot commented Nov 6, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 6, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5245 November 6, 2024 22:33 Inactive
Copy link
Contributor

github-actions bot commented Nov 6, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.57 KB (0%)
packages/react/dist/browser.umd.js 98.87 KB (0%)

Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: 0cdbd08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@francinelucca francinelucca added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 9, 2024
export default {
title: 'Private/Components/Overlay',
component: Overlay,
argTypes: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documented the props here because something about this merge type messes with how storybook reads docs 🤷🏽‍♀️

@francinelucca francinelucca added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit abd7578 Nov 14, 2024
53 of 54 checks passed
@francinelucca francinelucca deleted the francinelucca/5183-overlay---no-default-story branch November 14, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Overlay integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog staff Author is a staff member status: review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlay - No Default Story
2 participants