-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(AnchoredOverlay): add role, aria-label and aria-modal to stories #5184
Conversation
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing I could add is if we can add aria-label
to the examples that have role="dialog"
similar to #5186? Other than that, LGTM! 🚀
…ed-overlay-at-the-end-of-the-document-causing-content-ordermeaningful-sequence-failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes https://github.com/github/primer/issues/3450
Following strategy used in #5175, add proper role to AnchoredOverlay stories.
Changelog
New
role="dialog"
,aria-label
andaria-modal=true
toAnchoredOverlay
stories viaoverlayProps
Changed
hovercard
inAnchoredOverlay
stories to have more than one focus stopAnchoredOverlay
stories to havefocusZone
disabled so that the focus can be navigated through tabs instead of arrows.Rollout strategy
Docs only update
Testing & Reviewing
Test deployed storybook
AnchoredOverlay
stories. Verify:Merge checklist