Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SelectPanel: Update SelectPanel to use modern ActionList #4794
SelectPanel: Update SelectPanel to use modern ActionList #4794
Changes from 6 commits
9cee0a4
c7aa5de
40a0c45
344f6ce
fa5f5a6
3cd9ecc
0003e59
713b5ad
6fc7f2b
a246981
e209f47
26cddc1
b1199fb
b669cff
1012662
67dc5c9
c66feb5
4fbb3c5
2d5e2b2
cee7737
9c972c3
17e4ca8
26b6fe6
42c50c0
0d0004f
3ba9bc7
92ab9c2
7b3d5e6
1cf1e09
92303d0
4dc3b41
f673034
3a7d490
ab3ea9c
44ff862
46c94e6
ff8379b
9353d71
0a126ad
91cd5a3
40322c5
f0150e4
f72b9d4
85d0237
2eca9fa
c875223
02a6dc9
25c574a
5dc6adb
85e0bb4
0ee74e1
798008e
beca8db
14fd206
185eb17
318aa99
e9c523c
efd1216
cd9a931
619ff96
e3fe7b8
ebac341
0513474
2afa236
0f38bf4
f72aa55
6e9d706
0b57206
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is a common pattern, but I personally find it a bit confusing to use TitleCase for these renamed variables. Can we avoid renaming them, or name them something else, eg.
originalTrailingVisual
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋
the TitleCase is so that we can render them as a component in JSX
prop accepted as
leadingVisual
, rendered in the body as<LeadingVisual/>
, it would have been nicer if the prop was already TitleCased to signal that it accepts a component (and not a string, for example), but probably not the correct time to change that here