ActionMenu: Make sure event handlers on trigger are called #4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
siddharthkp
commented
Jun 6, 2024
•
siddharthkp
commented
- Fixes [ActionMenu.Button] onClick doesn't function #4647
- Merge event handlers from props and AnchoredOverlay
🦋 Changeset detectedLatest commit: 3e96d91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
siddharthkp
added
patch release
siddharthkp
changed the title
…ct into fix/actionmenu-button-onclick
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
|
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/341579 |
siddharthkp
added
integration-tests: passing
|
No breaking changes confirmed! |
joshblack
approved these changes
Sep 12, 2024
TylerJDev
pushed a commit
that referenced
this pull request
Sep 23, 2024
* wip: add mergeAnchorHandlers * merged onClick and onKeyDown in ActionMenu.Anchor * improve types * Create green-schools-smell.md * cover cases with Tooltip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.