Allow user to override Button and IconButton aria-disabled
#4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7248955 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Merged
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Allow user to override button `aria-disabled` * Add test * Add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3991
It looks like in #3582 we added support for
aria-disabledstyling on button components, which is awesome! Except that we accidentally introduced a regression where consumers cannot set thearia-disabledattribute on these components. This is because we are settingaria-disabledinButtonBaseafter we spread the consumer's props.The fix here is simply to move this line earlier, so the consumer can override the attribute.
Alternatively, we could instead force
aria-disabledto betruewhenloading, regardless of what the consumer sets, but then respect the consumer's prop all other times. That's not a hard change to make if we prefer to go that route.Changelog
Changed
aria-disabledattributeRollout strategy
Testing & Reviewing
Merge checklist